[Public] > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: Tuesday, June 10, 2025 9:53 PM > To: Penny, Zheng <penny.zh...@amd.com> > Cc: Huang, Ray <ray.hu...@amd.com>; Stefano Stabellini > <sstabell...@kernel.org>; Andrew Cooper <andrew.coop...@citrix.com>; Roger > Pau Monné <roger....@citrix.com>; Anthony PERARD > <anthony.per...@vates.tech>; Orzel, Michal <michal.or...@amd.com>; Julien > Grall <jul...@xen.org>; Stabellini, Stefano <stefano.stabell...@amd.com>; > Sergiy > Kibrik <sergiy_kib...@epam.com>; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v4 20/20] xen/sysctl: wrap around sysctl hypercall > > On 28.05.2025 11:17, Penny Zheng wrote: > > From: Stefano Stabellini <sstabell...@kernel.org> > > > > Wrap sysctl hypercall def and sysctl.o with CONFIG_SYSCTL, and since > > PV_SHIM_EXCLUSIVE needs sorting in the future, we move them out of > > PV_SHIM_EXCLUSIVE condition at the same time. > > > > We need to make SYSCTL with prompt back and state unsetting SYSCTL in > > pvshim_defconfig to explicitly make it unavailable for PV shim. > > I'm struggling with this sentence. but nevertheless it seems pretty clear > that what > the latter half of the sentence says is not the effect of ...
How about “ We shall add "#CONFIG_SYSCTL is not set" in pvshim_defconfig to at least provide correct preset for PV shim " > > > --- a/xen/arch/x86/configs/pvshim_defconfig > > +++ b/xen/arch/x86/configs/pvshim_defconfig > > @@ -31,3 +31,4 @@ CONFIG_EXPERT=y > > # HYPERV_HYPERV_GUEST is not set > > # CONFIG_HVM is not set > > # CONFIG_VGA is not set > > +# CONFIG_SYSCTL is not set > > ... this change. The option is still going to be available; it's just that > the preset is "off" > now. > > Jan
