On 20.06.2025 18:11, Ross Lagerwall wrote: > On Fri, Jun 20, 2025 at 10:53 AM Roger Pau Monné <roger....@citrix.com> wrote: >> >> On Mon, Jun 02, 2025 at 02:36:35PM +0100, Ross Lagerwall wrote: >>> In preparation for adding support for livepatch signing, add support for >>> RSA crypto. >>> >>> The RSA code is extracted from Nettle at tag nettle_3.2_release_20160128 >>> (https://git.lysator.liu.se/nettle/nettle). >>> >>> The MPI code is extracted from Linux at commit eef0df6a5953 (lib/mpi/*). >>> >>> Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> >>> --- >>> >>> In v3: >>> >>> * Move mpi.c to lib >>> * Fix header guard name >>> >>> xen/crypto/Makefile | 1 + >>> xen/crypto/rsa.c | 196 +++++ >>> xen/include/xen/mpi.h | 68 ++ >>> xen/include/xen/rsa.h | 74 ++ >>> xen/lib/Makefile | 1 + >>> xen/lib/mpi.c | 1729 +++++++++++++++++++++++++++++++++++++++++ >> >> Just FTAOD: all the functions imported in mpi.c are used I think? So >> that we don't introduce unreachable code. > > Yes, everything included here is used by the end of the patch series.
What about intermediate state? It's conceivable that such a series might go in piecemeal ... Jan
