On 22.06.2025 22:58, Stefano Stabellini wrote: > On Sun, 22 Jun 2025, Nicola Vetrini wrote: >> On 2025-06-21 04:19, Stefano Stabellini wrote: >>> --- a/xen/arch/x86/include/asm/cpufeatures.h >>> +++ b/xen/arch/x86/include/asm/cpufeatures.h >>> @@ -1,6 +1,6 @@ >>> -/* >>> - * Explicitly intended for multiple inclusion. >>> - */ >>> +/* This file is intended to be included multiple times. */ >>> +/* #ifndef X86_CPUFEATURES_H */ >>> +/* #define X86_CPUFEATURES_H */ >>> >> >> Are these two lines really needed? I may be mistaken, but I think the >> violation's first location would be the #include below with a comment a >> couple >> of lines above captured by the config at the top [1]. @Federico thoughts? > > Without these 2 lines, ECLAIR complains about the following: > > #include <xen/lib/x86/cpuid-autogen.h> > ^ > MC3A2.D4.10non-compliant start of header file
And that's where hence a SAF-8 comment cold be placed, I would think. Jan
