Hi Jan,

On 23/07/2025 17:27, Jan Beulich wrote:
> On 23.07.2025 16:05, Oleksii Moisieiev wrote:
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -19,6 +19,7 @@ config ARM
>>      select HAS_ALTERNATIVE if HAS_VMAP
>>      select HAS_DEVICE_TREE
>>      select HAS_DOM0LESS
>> +    select HAS_DOM0
> This wants to move one line up, for the set to remain sorted. But see below.
>
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -21,6 +21,14 @@ config DOM0LESS_BOOT
>>        Xen boot without the need of a control domain (Dom0), which could be
>>        present anyway.
>>   
>> +config DOM0_BOOT
>> +    bool "Dom0 boot support" if EXPERT
>> +    depends on HAS_DOM0 && HAS_DEVICE_TREE && DOMAIN_BUILD_HELPERS
>> +    default y
>> +    help
>> +      Dom0 boot support enables Xen to boot to the control domain (Dom0) and
>> +      manage domU guests using the Xen toolstack with provided 
>> configurations.
> What about non-Arm? x86 has a Dom0 too, but doesn't select HAS_DOM0. It
> actually requires a Dom0 for now, so to me HAS_DOM0 is a misnomer. Maybe
> HAS_OPTIONAL_DOM0?
Right now DOM0_BOOT is the only option for x86 so I've made the changes 
only for arm.
But I'm still leaving these options in common because IIUC dom0less for 
x86/hyperlauch support
is in merge process right now. So once it merged this parameter could be 
used for x86 arch.
>> @@ -92,6 +100,9 @@ config HAS_DEVICE_TREE
>>   config HAS_DOM0LESS
>>      bool
>>   
>> +config HAS_DOM0
>> +    bool
> Same here as to sorting, no matter that ...
>
+
>>   config HAS_DIT # Data Independent Timing
>>      bool
>>   
> ... HAS_DOM0LESS and this one are misplaced with one another.
>
> Jan

Reply via email to