On 24.07.2025 04:17, dm...@proton.me wrote:
> On Wed, Jul 23, 2025 at 06:24:07PM +0000, dm...@proton.me wrote:
>> On Wed, Jul 23, 2025 at 05:10:04PM +0200, Jan Beulich wrote:
>>> On 23.07.2025 02:11, dm...@proton.me wrote:
>>>> @@ -559,7 +559,8 @@ void hvm_do_resume(struct vcpu *v)
>>>> static int cf_check hvm_print_line(
>>>> int dir, unsigned int port, unsigned int bytes, uint32_t *val)
>>>> {
>>>> - struct domain *cd = current->domain;
>>>> + struct domain *d = current->domain;
>>>
>>> Why the renaming? (Iff any renaming was needed here, then please to currd.)
>>
>> It was requested earlier:
>> https://lore.kernel.org/all/1ac74dd3-e0c5-43e5-9eed-c1a2cc17d...@suse.com/
>>
>
> What would be the preferred way to address this?
>
> Add `const` to domain pointer?
> `s/cd/currd/`?
> `s/cd/d/` like in previous review?
> Do not touch `cd`?
>
> It make sense to adjust the code now by at least adding `const`.
Yet only if the line needs touching anyway for the purpose of the patch.
Which, as it looks, isn't necessary.
Jan
