On 2025-08-05 14:38, Grygorii Strashko wrote:
Hi Jason,
On 05.08.25 20:21, Jason Andryuk wrote:
On 2025-08-01 11:54, Grygorii Strashko wrote:
From: Grygorii Strashko <grygorii_stras...@epam.com>
Call stack for dom0less hwdom case (1:1) memory:
create_domUs
|-construct_domU
|-construct_hwdom()
|-allocate_memory_11()
And allocate_memory_11() uses "dom0_mem" as:
min_low_order =
get_order_from_bytes(min_t(paddr_t, dom0_mem, MB(128)));
In case of dom0less boot the "dom0_mem" is not used and defaulted to 0,
which causes min_low_order to get high value > order and so no
allocations
happens from low memory.
Fix it, by using kinfo->unassigned_mem instead of "dom0_mem" has correct
memory size in both cases: regular dom0 boot and dom0less boot.
Fixes: 43afe6f030244 ("xen/common: dom0less: introduce common
dom0less-build.c")
I think I introduced this bug with the dom0less hwdom support, and the
correct fixes is:
Fixes: 52cb53f1816a ("xen/arm: dom0less hwdom construction")
Signed-off-by: Grygorii Strashko <grygorii_stras...@epam.com>
dom0_mem is also mentioned in the comment on line 252. With that
changed as well:
Reviewed-by: Jason Andryuk <jason.andr...@amd.com>
Will smth like below be ok?
* We first allocate the largest allocation we can as low as we
* can. This then becomes the first bank. This bank must be at least
- * 128MB (or dom0_mem if that is smaller).
+ * 128MB (or memory size requested for domain if that is smaller).
LGTM - Thank you.
-Jason
