On 07.08.2025 14:00, Oleksii Kurochko wrote: > On 8/5/25 12:37 PM, Jan Beulich wrote: >> On 31.07.2025 17:58, Oleksii Kurochko wrote: >>> + /* >>> + * Return back nr_root_pages to assure the root table memory is also >>> + * accounted against the P2M pool of the domain. >>> + */ >>> + if ( !paging_ret_pages_to_domheap(d, nr_root_pages) ) >>> + return -ENOMEM; >>> + >>> + page = p2m_allocate_root(d); >>> + if ( !page ) >>> + return -ENOMEM; >> Hmm, and the pool is then left shrunk by 4 pages? > > Yes until they are used for root table it shouldn't be in p2m pool (freelist), > when root table will be freed then it makes sense to return them back. > Am I missing something?
I'm commenting specifically on the error path here. > Probably, you meant that it is needed to update p2m->pages? That (I think) I commented on elsewhere, yes. Jan
