On 08/08/2025 11:43 am, Kevin Lampis wrote: > diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c > index d60a07bfd5..95a626f49c 100644 > --- a/xen/arch/x86/acpi/cpu_idle.c > +++ b/xen/arch/x86/acpi/cpu_idle.c > @@ -1059,8 +1059,8 @@ static void acpi_processor_power_init_bm_check(struct > acpi_processor_flags *flag > * is not required while entering C3 type state on > * P4, Core and beyond CPUs > */ > - if ( c->x86_vendor == X86_VENDOR_INTEL && > - (c->x86 > 0x6 || (c->x86 == 6 && c->x86_model >= 14)) ) > + if ( c->vendor == X86_VENDOR_INTEL && > + (c->family > 0x6 || (c->family == 6 && c->model >= 14)) ) > flags->bm_control = 0; > }
One of the purposes of the name change was to audit every use of these fields for safety. This is an example which needs reworking. It is technically safe with Family 18/19, because of the way the relation works, but > @@ -468,8 +468,8 @@ static void Intel_errata_workarounds(struct > cpuinfo_x86 *c) } } - if (c->x86 == 6 && cpu_has_clflush && - > (c->x86_model == 29 || c->x86_model == 46 || c->x86_model == 47)) + if > (c->family == 6 && cpu_has_clflush && + (c->model == 29 || c->model == > 46 || c->model == 47)) setup_force_cpu_cap(X86_BUG_CLFLUSH_MONITOR); > probe_c3_errata(c); This is one which wants converting to using real CPU names. Also, this really cannot be one giant patch. It's unreviewable by shear volume of change (and isn't a mechanical change that can be trivially confirmed). Perhaps start by doing a patch covering mcheck (but even then you've got one conversion to a real CPU name I can see), and one covering vPMU. They're both not oneliners, and about the right order of magnitude for a change like this. ~Andrew
