On 14.08.2025 18:03, Roger Pau Monne wrote: > Deferring the p2m unpopulate of the MSI-X table region to after the BAR are > mapped in the p2m is not needed.
For my own understanding: This is because we would never actively map such a region; we always subtract it out of what is going to be mapped. If so ... > The aim of vpci_make_msix_hole() is to > cope with the BAR containing the MSI-X table being positioned over a > reserved e820 region, by making sure the MSI-X table region is > unpopulated on the p2m. Note that reserved e820 regions are identity mapped > in the hardware domain p2m by default. > > Doing it before or after the BAR p2m changes are done is irrelevant, hence > do it ahead of the p2m changes, as that's simpler. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan
