On 16.08.2025 13:19, Bernhard Kaindl wrote: > The static per-NUMA-node count of free pages is the sum of free memory > in all zones of a node. It's an optimisation to avoid doing that operation > frequently in the following patches that introduce per-NUMA-node claims. > > --- > Changed since v1: > - Added ASSERT(per_node_avail_pages[node] >= request) as requested > during review by Roger: Comment by me: As we have > ASSERT(avail[node][zone] >= request); > directly before it, request is already valid, so this checks > that per_node_avail_pages[node] is not mis-accounted too low.
Okay, this addresses Roger's comment. What about mine, though? > Signed-off-by: Bernhard Kaindl <bernhard.kai...@cloud.com> > Signed-off-by: Alejandro Vallejo <alejandro.garciavall...@amd.com> Apart from similar concerns as for patch 2, these come too late. They wouldn't end up in the commit message, due to the earlier --- separator. Given the problems with the first three patches I'm going to stop review here, expecting a tidied v3 to be submitted with all prior review comments addressed (verbally or by respective adjustments). Jan
