On 28.08.2025 17:03, Andrew Cooper wrote: > FRED and IDT differ by a Supervisor Token on the base of the shstk. This > means that the value they load into MSR_PL0_SSP differs by 8. > > s3_resume() in particular has logic which is otherwise invariant of FRED mode, > and must not clobber a FRED MSR_PL0_SSP with an IDT one. > > This also simplifies the AP path too. Updating reinit_bsp_stack() is deferred > until later.
This last sentence looks to be ... > No functional change. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Roger Pau Monné <roger....@citrix.com> > > v2: > * Extend comment about clearing the busy bit. > * Move reinit_bsp_stack() hunk into this patch. ... stale, according to this. Other than that: Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan