On 08.10.2025 18:23, Roger Pau Monné wrote:
> On Wed, Oct 08, 2025 at 02:08:48PM +0200, Jan Beulich wrote:
>> @@ -1439,7 +1438,7 @@ static void vlapic_do_init(struct vlapic
>> if ( !has_vlapic(vlapic_vcpu(vlapic)->domain) )
>> return;
>>
>> - vlapic_set_reg(vlapic, APIC_LVR, VLAPIC_VERSION);
>> + vlapic_set_reg(vlapic, APIC_LVR, 0x00050014);
>
> (Maybe I'm getting ahead of patch 3, as I haven't looked yet)
>
> Don't we want to use some kind of macros to build this in a more
> friendly way?
>
> We could have a pair of SET_APIC_{VERSION,MAXLVT}()?
With what patch 3 does to apicdef.h, I was rather wondering whether to simply
use two MASK_INSR() here (patch 3 already uses one right now).
Jan
