On 11.11.2025 18:54, Grygorii Strashko wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -311,6 +311,15 @@ struct vcpu
> #endif
> };
>
> +static inline bool vcpu_is_hcall_compat(const struct vcpu *v)
Does the vcpu_ prefix really buy us much here? The per-vCPU aspect is already
conveyed by the function parameter, I'd say.
Actually - is a parameter in fact needed? It's always current afaics. (Then,
if the parameter was to stay for some reason, it would want naming "curr".)
> +{
> +#ifdef CONFIG_COMPAT
> + return v->hcall_compat;
As long as you don't remove the struct field, ...
> +#else
> + return false;
> +#endif /* CONFIG_COMPAT */
... why not
return IS_ENABLED(CONFIG_COMPAT) && v->hcall_compat;
?
Jan
