"Dr. David Alan Gilbert" <[email protected]> writes: > * Markus Armbruster ([email protected]) wrote: >> Error messages change from >> >> Can't open /dev/ip (actually /dev/udp) >> Can't open /dev/tap >> Can't open /dev/tap (2) >> >> to >> >> Could not open '/dev/udp': REASON >> Could not open '/dev/tap': REASON >> >> where REASON is the value of strerror(errno). > > I guess the new macro has a __LINE__ so the (2) is redundant.
It does capture __FILE__, __LINE__, and __func__, but they're only printed for &error_abort. How likely is it that the first open of /dev/tap succeeds, and the second fails? Do users users then need to know that the second failed? If yes, then " (2)" is a terrible way to tell them. >> Signed-off-by: Markus Armbruster <[email protected]> > > Reviewed-by: Dr. David Alan Gilbert <[email protected]> Thanks!
