Reviewed-by: Kostiantyn Kostiuk <[email protected]> On Thu, Nov 20, 2025 at 9:14 PM Markus Armbruster <[email protected]> wrote:
> We include numeric GetLastError() codes in error messages in a few > places, like this: > > error_setg(errp, "GRIPE: %d", (int)GetLastError()); > > Show text instead, like this: > > error_setg_win32(errp, GetLastError(), "GRIPE"); > > Signed-off-by: Markus Armbruster <[email protected]> > --- > qga/commands-win32.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index acc2c11589..0fd0c966e4 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -1798,8 +1798,8 @@ void qmp_guest_set_time(bool has_time, int64_t > time_ns, Error **errp) > tf.dwHighDateTime = (DWORD) (time >> 32); > > if (!FileTimeToSystemTime(&tf, &ts)) { > - error_setg(errp, "Failed to convert system time %d", > - (int)GetLastError()); > + error_setg_win32(errp, GetLastError(), > + "Failed to convert system time"); > return; > } > > @@ -1810,7 +1810,8 @@ void qmp_guest_set_time(bool has_time, int64_t > time_ns, Error **errp) > } > > if (!SetSystemTime(&ts)) { > - error_setg(errp, "Failed to set time to guest: %d", > (int)GetLastError()); > + error_setg_win32(errp, GetLastError(), > + "Failed to set time to guest"); > return; > } > } > @@ -1834,13 +1835,12 @@ GuestLogicalProcessorList > *qmp_guest_get_vcpus(Error **errp) > (length > sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION))) { > ptr = pslpi = g_malloc0(length); > if (GetLogicalProcessorInformation(pslpi, &length) == FALSE) { > - error_setg(&local_err, "Failed to get processor information: > %d", > - (int)GetLastError()); > + error_setg_win32(&local_err, GetLastError(), > + "Failed to get processor information"); > } > } else { > - error_setg(&local_err, > - "Failed to get processor information buffer length: > %d", > - (int)GetLastError()); > + error_setg_win32(&local_err, GetLastError(), > + "Failed to get processor information buffer > length"); > } > > while ((local_err == NULL) && (length > 0)) { > -- > 2.49.0 > >
