On Mon, 8 Dec 2025 at 13:38, Jan Beulich <[email protected]> wrote: > > On 08.12.2025 14:31, Frediano Ziglio wrote: > > On Mon, 8 Dec 2025 at 08:25, Jan Beulich <[email protected]> wrote: > >> > >> On 05.12.2025 17:09, Frediano Ziglio wrote: > >>> From: Frediano Ziglio <[email protected]> > >>> > >>> For xen.gz file we strip all symbols and have an additional > >>> xen-syms.efi file version with all symbols. > >>> Make xen.efi more coherent stripping all symbols too. > >>> xen-syms.efi can be used for debugging. > >>> > >>> Signed-off-by: Frediano Ziglio <[email protected]> > >>> --- > >>> Changes since v1: > >>> - avoid leaving target if some command fails. > >>> > >>> Changes since v2: > >>> - do not convert type but retain PE format; > >>> - use xen-syms.efi for new file name, more consistent with ELF. > >>> > >>> Changes since v3: > >>> - update documentation; > >>> - do not remove xen.efi.elf; > >>> - check endbr instruction before generating final target. > >>> > >>> Changes since v4: > >>> - simplify condition check; > >>> - avoid reuse of [email protected] file. > >>> > >>> Changes since v5: > >>> - avoid creation of temporary file. > >>> > >>> Changes since v6: > >>> - install xen-syms.efi; > >>> - always strip xen.efi; > >>> - restore EFI_LDFLAGS check during rule execution; > >>> - update CHANGELOG.md; > >>> - added xen-syms.efi to .gitignore. > >>> > >>> Changes since v7: > >>> - move and improve CHANGELOG.md changes. > >>> > >>> Changes since v8: > >>> - rebase on master; > >>> - clean xen-syms.efi file. > >> > >> I.e. not addressing my prior, more fundamental comments. > > > > In version 8 you commented that code should not double linking, and > > the current version does not double link. > > That was the reply directly to you. There was also a reply to Marek's > comments, > as to extending the probing of the toolchain that we do to figure out how well > the PE/COFF linking actually works. > > Jan
Surely it would be good to have, but it looks out of scope here, we already agreed that the current build produces artifacts with issues and we already agree that this change should be integrated to solve such issues. On checking linking one simple thing would be to check that objdump has no complaints (like a line like "objdump -x xen.efi > /dev/null" in the Makefile). I have a patch that does not tweak and checks on the xen.efi file and there was a similar code posted a while ago but that's surely out of scope. Frediano
