Ian Campbell writes ("Re: [PATCH OSSTEST] Add basic PVH flights."): > On Wed, 2014-12-10 at 13:56 +0000, Ian Jackson wrote: > > This should probably be > > > > + $cfg =~ s/^pvh\b.*//mg; > > > > unless you deliberately intend to strip out any other phv-related > > settings which xen-create-image might put there ? > > Nope, your suggest is a good one. > > Shall I resent or are you ok for me to do this change as I commit?
Please go ahead, but can you please first double check that it still does actually still edit the config file as desired and cause the test failure on your machine ? It would be annoying if that line ceased to take effect and the job spuriously passed. That said, Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel