On 19/01/15 08:19, Oleksandr Dmytryshyn wrote:
> +
> +struct sndif_request_open {
> + unsigned int dev_num;
> + unsigned int card_num;
> + unsigned int dev_type;
> + unsigned int _pad1;
> + uint64_t id; /* private guest value, echoed in resp */
> + unsigned int _pad2;
> + unsigned int _pad3;
> +} __attribute__((__packed__));
Using types like unsigned int will break 32-bit guests talking to 64-bit
backends.
Always use fixed width types, naturally align them and use explicit
padding. The packed attribute will be unnecessary.
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
