Ian Campbell writes ("[PATCH OSSTEST v2 13/18] Toolstack: Refactor save/restore
support"):
> Still stubbed out for libvirt.
...
> +sub restore ($$$$$) {
> + my ($self,$gho,$f,$cfg,$to) = @_;
> + my $ho = $self->{Host};
> + my $gn = $gho->{Name};
> + target_cmd_root($ho,
> + $self->{Command}
> + ." restore "
> + .($self->{RestoreNeedsConfig} ? $cfg : '')
> + ." $f", $to);
Why pass the $cfg explicitly to restore() when we can get it out of
$gho ? I notice that the timeout here is in the argument list where
it should be.
But, please call the timeout variable `$timeout', not `$to'. That's
what it's called elsewhere.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
