Jan Beulich writes ("Re: [PATCH] tools: work around collision of -O0 and
-D_FORTIFY_SOURCE"):
> On 05.02.15 at 17:36, <[email protected]> wrote:
> > +AC_DEFUN([AX_CHECK_PYTHON_FORTIFY_NOOPT], [
> > + AC_CACHE_CHECK([whether Python setup.py brokenly enables
> > -D_FORTIFY_SOURCE],
>
> I guess the people having added that would not like to see this
> called "brokenly".
I think it is correct, and that it is fair to make such a criticism in
a configure script. If this is too rude I guess we could say
`unfortunately'.
> > --- a/tools/Rules.mk
> > +++ b/tools/Rules.mk
> > @@ -56,7 +56,7 @@ SHLIB_libxenvchan = -Wl,-rpath-link=$(XEN_LIBVCHAN)
> >
> > ifeq ($(debug),y)
> > # Disable optimizations and enable debugging information for macros
> > -CFLAGS += -O0 -g3
> > +CFLAGS += -O0 -g3 $(PY_NOOPT_CFLAGS)
>
> Why would you do this for all of the tools build rather than just the
> python components?
You're right. This should be something like:
CFLAGS += -O0 -g3
+PY_CFLAGS += $(PY_NOOPT_CFLAGS)
and including PY_CFLAGS in tools/python/Makefile etc.
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
