On Thu, Mar 30, 2017 at 03:58:25PM +0800, Haozhong Zhang wrote: > On 03/29/17 21:11 -0700, Dan Williams wrote: > > On Sun, Mar 19, 2017 at 5:09 PM, Haozhong Zhang > > <haozhong.zh...@intel.com> wrote: > > > xen-ndctl is a tool for users in Dom0 to setup the host pmem with Xen > > > hypervisor. It's used to specify the storage, which is either the > > > regular RAM or a pmem range, to manage the specified pmem. > > > > > > Signed-off-by: Haozhong Zhang <haozhong.zh...@intel.com> > > > --- > > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > > > Cc: Wei Liu <wei.l...@citrix.com> > > > --- > > > > I would be open to moving this tooling into upstream ndctl [1]. > > Especially since you're reusing the same name it would be confusing to > > have 2 ndctl tools. > > > > [1]: https://github.com/pmem/ndctl > > Then it could leverage existing code in ndctl (e.g. getting parameters > from a device name rather than using address in my current implementation). > > I'm not sure about Xen's policy whether a tool should be included in > Xen or can be left in 3rd party program. Let's wait for Xen maintainers' > reply.
No problems. For example QEMU has it (it has an configure to detect the headers and then uses xc_XYZ calls). Also kexec-tools does it as well. The big thing that you have to keep in mind is to make the hypercall as future proof as possible - so you don't have #ifdef all over the code. > > Thanks, > Haozhong _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
