On Fri, 2017-04-07 at 11:45 +0100, George Dunlap wrote: > On 06/04/17 09:16, Dario Faggioli wrote: > > Since we're holding the lock on the pCPU from which we > > are trying to steal, it can't have disappeared, so we > > can drop the check for that (and convert it in an > > ASSERT()). > > > > And since we try to steal only from busy pCPUs, it's > > unlikely for such pCPU to be idle, so we mark it as > > such (and bail early if it unfortunately is). > > Oh, you mean "mark the test as unlikely". I initially parsed this > as, > "Mark the pcpu as idle", which confused me. > > Can I change this to, "tell the compiler that it's unlikely"? > Indeed. AFAICS, I'll have to resend, so I will do this myself.
> Either way: > > Reviewed-by; George Dunlap <george.dun...@citrix.com> > Thanks, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel