>>> On 21.04.17 at 12:13, <wei.l...@citrix.com> wrote: > On Wed, Apr 19, 2017 at 09:12:54AM -0600, Jan Beulich wrote: >> >>> On 03.04.17 at 13:22, <wei.l...@citrix.com> wrote: >> > @@ -4300,6 +4297,15 @@ int create_grant_host_mapping(uint64_t addr, >> > unsigned long frame, >> > return create_grant_va_mapping(addr, pte, current); >> > } >> > >> > +int create_grant_host_mapping(uint64_t addr, unsigned long frame, >> > + unsigned int flags, unsigned int >> > cache_flags) >> > +{ >> > + if ( paging_mode_external(current->domain) ) >> > + return create_grant_p2m_mapping(addr, frame, flags, cache_flags); >> > + >> > + return create_grant_pv_mapping(addr, frame, flags, cache_flags); >> > +} >> >> I wonder whether this and its siblings wouldn't better become inline >> functions. > > Do you want me to just add "inline"? That's fine by me.
Well, plus "static", i.e. the implication was for them to also move to asm-x86/grant_table.h then. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel