On 12/05/17 10:15, Roger Pau Monné wrote:
> On Thu, May 11, 2017 at 10:29:42AM -0600, Charles Arnold wrote:
>> The Requires line in this config file uses the wrong names for two
>> dependencies.
>>
>> The package config file for xenctrl is called 'xencontrol' and for blktapctl
>> is
>> called 'xenblktapctl'. Running a command like 'pkg-config --exists xenlight'
>> will
>> fail without this fix.
>>
>> Signed-off-by: Charles Arnold <carn...@suse.com>
>>
>> diff --git a/tools/libxl/xenlight.pc.in b/tools/libxl/xenlight.pc.in
>> index 71d093a0ae..86c38a5634 100644
>> --- a/tools/libxl/xenlight.pc.in
>> +++ b/tools/libxl/xenlight.pc.in
>> @@ -9,4 +9,4 @@ Description: The Xenlight library for Xen hypervisor
>> Version: @@version@@
>> Cflags: -I${includedir}
>> Libs: @@libsflag@@${libdir} -lxenlight
>> -Requires.private: xentoollog,xenevtchn,xenctrl,xenguest,xenstore,blktapctl
>> +Requires.private:
>> xentoollog,xenevtchn,xencontrol,xenguest,xenstore,xenblktapctl
>
> Shouldn't xenblktapctl be conditional on whether blktap is actually enabled?
> FreeBSD/NetBSD don't support blktap at all, and on Linux it can be disabled
> with "--disable-blktap2" IIRC.
You are right. I suggest to take Charles' patch and I'll post another
one on top of it handling availability of blktap.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
