At 15:12 +0000 on 19 Feb (1424355171), Jan Beulich wrote: > >>> On 19.02.15 at 15:47, <malcolm.cross...@citrix.com> wrote: > > Tim suggested posting this patch to see what general opinion was to this > > style of backport fix. I attempted to backport the EPT misconfig to Xen > > 4.4 but I ended up with quite a large number of patches and got > > concerned there would be a subtle error in my backport. > > Yeah, your change is certainly much smaller, so I'm not opposed > to going this route. I've Cc-ed Tim now so he could chime in if at > this point he thinks differently.
I still think this is the better path - especially once it's been adjusted as Jan suggests to make the patch even smaller and clearer. One other comment, if you're respinning: > >>> + uint64_t mtrr_def_type = rdmsr(MSR_MTRRdefType); > >>> + wrmsr(MSR_MTRRdefType, (1u << 11) | 6); Can this magic constant have a comment? When it's used in cacheattr.c it's commented as '/* E, default type WB */'. Cheers, Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
