>>> On 12.05.17 at 18:25, <olekst...@gmail.com> wrote: > On Fri, May 12, 2017 at 7:17 PM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 12.05.17 at 17:50, <olekst...@gmail.com> wrote: >>> On Fri, May 12, 2017 at 5:23 PM, Jan Beulich <jbeul...@suse.com> wrote: >>>>>>> On 10.05.17 at 16:03, <olekst...@gmail.com> wrote: >>>>> @@ -771,6 +773,47 @@ int amd_iommu_unmap_page(struct domain *d, unsigned >>>>> long gfn) >>>>> return 0; >>>>> } >>>>> >>>>> +/* TODO: Optimize by squashing map_pages/unmap_pages with >>>>> map_page/unmap_page */ >>>> >>>> Looking over the titles of the rest of this series it doesn't look like >>>> you're eliminating this TODO later. While I appreciate this not >>>> being done in the already large patch, I don't think such a TODO >>>> should be left around. If need be (e.g. because you can't test >>>> the change), get in touch with the maintainer(s). >>> I will drop this TODO everywhere. >> >> By "drop" you mean "address" or really just "drop"? > I meant just drop.
Then I'm sorry, but no, this is not a way to address the comment I've made. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
