>>> On 31.05.17 at 13:34, <[email protected]> wrote: > On 31/05/17 08:22, Jan Beulich wrote: >> - constify parameter >> - use accessors >> - drop stray casts >> - adjust formatting >> >> Signed-off-by: Jan Beulich <[email protected]> > > Given the const, why switch to using accessors? There are no issues > with cleanbits.
I consider it wrong to open code things which have accessors. Otherwise you could ask why there are "get" accessors at all. Also the nice thing about using them is that they'll hide the otherwise ugly (imo) leading underscores of the field names. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
