Hi Tamas, [...]
>> + >> + if ( ((flag & GV2M_WRITE) == GV2M_WRITE) && !(perms & GV2M_WRITE) ) > > Wouldn't it be enough to do (flag & GV2M_WRITE) without the following > comparison? Also, a comment explaining why this is an error-condition > would be nice. > Yes, you are absolutely correct: (flag & GV2M_WRITE) is already sufficient. I will adapt the upper if-statement and add a comment in the next version of my patch series. Cheers, ~Sergej _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
