On 06/21/2017 07:06 PM, Jan Beulich wrote: >>>> On 21.06.17 at 16:56, <rcojoc...@bitdefender.com> wrote: >> --- a/xen/arch/x86/monitor.c >> +++ b/xen/arch/x86/monitor.c >> @@ -133,7 +133,8 @@ int arch_monitor_domctl_event(struct domain *d, >> bool_t old_status; >> >> /* sanity check: avoid left-shift undefined behavior */ >> - if ( unlikely(mop->u.mov_to_cr.index > 31) ) >> + if ( unlikely(mop->u.mov_to_cr.index >= >> + ARRAY_SIZE(ad->monitor.write_ctrlreg_mask)) ) > > Indentation.
Right, that should have matched the end of the "unlikely(" above. I'll modify it, remove the comment Wei commented on and submit V3. Thanks, Razvan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel