>>> On 30.06.17 at 17:04, <andrew.coop...@citrix.com> wrote:
> + case x86_seg_ds:
> + case x86_seg_es:
> + if ( (reg->attr.fields.type & 0x8) && !(reg->attr.fields.type & 0x2)
> )
> + {
> + gprintk(XENLOG_ERR, "Non-readable segment provided for DS or
> ES\n");
> + return -EINVAL;
> + }
> + break;
> +
> + default: /* -Werror=switch */
> + break;
> }
Perhaps better to have
default:
ASSERT_UNREACHABLE();
case x86_seg_tr:
break;
to make more visible that it is not an oversight that especially FS
and GS aren't being handled here? Either way
Reviewed-by: Jan Beulich <jbeul...@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
