On Fri, 2017-07-14 at 06:28 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 14.07.17 at 10:26, <kpraveen.l...@gmail.com> wrote: > > The patch aligns the coding style of rbtree related files to Linux > > coding > > conventions to have limited conflicts in future while porting from > > Linux > > tree. > > > > This patch includes only the style changes. > > Certainly not: In the header you introduce at least 3 new inline > functions. Please be _really_ careful with such statements. > > Jan > Agreed, I shouldn't have added. rbtree.h file does include incline functions which are actually commented, and in order to have complete similarity I did include the same here.
Also, rbtree.c does have comment in header note being modified, for the same reason. Further, do you suggest to keep the old ones, but that may cause porting issue and it won't be exact replica from Linux base. Please suggest. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
