Felix Schmoll writes ("[PATCH v2] xenconsole: Add pipe option"):
> Add pipe option to xenconsole that forwards console input.Thanks. IMO the commit message could do with better explanation. It should mention that xenconsole has a strange behaviour where it doesn't forward stdin unless stdin and stdout are both ttys, and your option is to disable this. Also "interactive" (used in the code) is a bit of a funny name for this, but "pipe" is worse IMO. It would work fine for a socket (eg from inetd), for example. How about calling the option "--interactive" or "--bidirectional" or something ? The code LGTM. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
