On Wed, Jul 19, 2017 at 10:42 PM, Julien Grall <julien.gr...@arm.com> wrote: > Hi Vijay, > > On 18/07/17 12:41, vijay.kil...@gmail.com wrote: >> >> From: Vijaya Kumar K <vijaya.ku...@cavium.com> >> >> memnode_shift variable is changed from int to unsigned int. >> With this change, compute_memnode_shift() returns error value >> instead of returning shift value. The memnode_shift is updated inside >> compute_memnode_shift(). >> >> Also, following changes are made >> - Rename compute_hash_shift to compute_memnode_shift >> - Update int to unsigned int for params in extract_lsb_from_nodes() >> - Return values of populate_memnodemap() is changed > > > I am not sure to understand the rationale behind changing the return value > of populate_memnodemap. Likely this mean a bit more description in the > commit message.
There is no much rationale behind it. As a part of cleanup, I have made meaningful return values. Anyway, I will update commit message. > > Cheers, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
