>>> Yi Sun <yi.y....@linux.intel.com> 07/15/17 2:47 AM >>>
>@@ -619,6 +710,46 @@ static int insert_val_into_array(uint32_t val[],
>enum cbm_type type,
>uint32_t new_val)
>{
>+ const struct feat_node *feat;
>+ const struct feat_props *props;
>+ unsigned int i;
>+ int ret;
>+
>+ ASSERT(feat_type < FEAT_TYPE_NUM);
>+
>+ ret = skip_prior_features(&array_len, feat_type);
>+ if ( ret < 0 )
>+ return ret;
>+ else
>+ val += ret;
Please avoid such pointless "else".
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
