On 08/09/2017 03:07 AM, Juergen Gross wrote:
Add a sysctl hypercall to support setting parameters similar to
command line parameters, but at runtime. The parameters to set are
specified as a string, just like the boot parameters.

Looks good, except for one thing:

+    case XEN_SYSCTL_set_parameter:
+        return domain_has_xen(current->domain, XEN2__SET_PARAMETER);

This needs to use SECCLASS_XEN2, but domain_has_xen uses SECCLASS_XEN.
I will be sending a patch fixing the other two incorrect users above
in that switch statement.

Xen-devel mailing list

Reply via email to