On 15/08/17 15:41, Jan Beulich wrote: > They're private to grant_table.c. > > Signed-by: Jan Beulich <jbeul...@suse.com> > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -158,7 +158,24 @@ shared_entry_header(struct grant_table * > > /* Active grant entry - used for shadowing GTF_permit_access grants. */ > struct active_grant_entry { > - uint32_t pin; /* Reference count information. */ > + uint32_t pin; /* Reference count information: */ > + /* Count of writable host-CPU mappings. */ > +#define GNTPIN_hstw_shift (0) > +#define GNTPIN_hstw_inc (1 << GNTPIN_hstw_shift) > +#define GNTPIN_hstw_mask (0xFFU << GNTPIN_hstw_shift) > + /* Count of read-only host-CPU mappings. */ > +#define GNTPIN_hstr_shift (8) > +#define GNTPIN_hstr_inc (1 << GNTPIN_hstr_shift) > +#define GNTPIN_hstr_mask (0xFFU << GNTPIN_hstr_shift) > + /* Count of writable device-bus mappings. */ > +#define GNTPIN_devw_shift (16) > +#define GNTPIN_devw_inc (1 << GNTPIN_devw_shift) > +#define GNTPIN_devw_mask (0xFFU << GNTPIN_devw_shift) > + /* Count of read-only device-bus mappings. */ > +#define GNTPIN_devr_shift (24) > +#define GNTPIN_devr_inc (1 << GNTPIN_devr_shift) > +#define GNTPIN_devr_mask (0xFFU << GNTPIN_devr_shift)
I would recommend taking the opportunity to switch these definitions to 1u << GNTPIN_*, as they are always used with unsigned types. Either way, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel