> -----Original Message----- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Vitaly Kuznetsov > Sent: 05 September 2017 17:49 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Stefano Stabellini <sstabell...@kernel.org>; Wei Liu > <wei.l...@citrix.com>; Andrew Cooper <andrew.coop...@citrix.com>; Tim > (Xen.org) <t...@xen.org>; George Dunlap <george.dun...@citrix.com>; > xen-devel@lists.xen.org; Jan Beulich <jbeul...@suse.com>; Ian Jackson > <ian.jack...@citrix.com> > Subject: Re: [Xen-devel] [PATCH] xen: reset creation_finished flag on soft > reset > > Paul Durrant <paul.durr...@citrix.com> writes: > > >> Paul Durrant <paul.durr...@citrix.com> writes: > >> > >> > > >> > I wonder whether the easiest thing to do would be to modify qemu trad > >> > to do explicit ioreq server creation? It's really not that much > >> > code-change... 20-30 lines or so. > >> > >> I was thinking about this too, I'll try. It will hopefuly allow to get > >> rid of the 'side effect' which creates default ioreq server on HVM > >> parameters read. > > > > Yes indeed. At that point I'd actually propose getting rid of those params > altogether since nothing will use them anymore. > > > > And in addition to that we don't need the concept of > 'default_ioreq_server' and special pathes for it all over the code. That > would be ideal, but: > > I tried switching qemu-traditional to the new API and even succeeded, > everything including pci pass-through seems to work. However, I'm not > anywhere close to '20-30 lines' -- it's an order of magnitude more :-) >
Well, the compat code does rather bloat it but I guess it is probably necessary. Xen has had ioreq servers for a long time but probably not long enough. > Anyway, here is the patch (attached). If everyone agrees the change is > appropriate for qemu-traditional I can sent it out. No additional > changes to the hypervisor is required. > LGTM so I think it's worth sending out. Cheers, Paul > -- > Vitaly _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
