On 17-09-20 09:36:13, Roger Pau Monn� wrote: > On Wed, Sep 20, 2017 at 11:06:57AM +0800, Yi Sun wrote: > > On 17-09-18 18:16:40, Roger Pau Monn� wrote: > > > On Tue, Sep 05, 2017 at 05:32:23PM +0800, Yi Sun wrote: > > > > +* xl interfaces: > > > > + > > > > + 1. `psr-mba-show [domain-id]`: > > > > > > Is this limited to domain-id, or one can also use the domain name? > > > Most of the xl commands accept either a domain-id or a domain-name. > > > > > Both domain-id and domain-name can show it. I thought this is by default and > > no need to explicitly declare. If I am wrong, I will change it as below: > > `psr-mba-show [domain-id/domain-name]` > > [domain-id|domain-name] > > Would be better IMHO. > Thanks!
> > > > + > > > > + 3. DOMCTL: > > > > + - XEN_DOMCTL_PSR_MBA_OP_GET_THRTL: Get throttling for a > > > > domain. > > > > + - XEN_DOMCTL_PSR_MBA_OP_SET_THRTL: Set throttling for a > > > > domain. > > > > + > > > > +* xl interfaces: > > > > + > > > > + 1. psr-mba-show [domain-id] > > > > + Show system/domain runtime MBA throttling value. For linear > > > > mode, > > > > + it shows the decimal value. For non-linear mode, it shows > > > > hexadecimal > > > > + value. > > > > + => > > > > XEN_SYSCTL_PSR_MBA_get_info/XEN_DOMCTL_PSR_MBA_OP_GET_THRTL > > > > + > > > > + 2. psr-mba-set [OPTIONS] <domain-id> <throttling> > > > > + Set bandwidth throttling for a domain. > > > > + => XEN_DOMCTL_PSR_MBA_OP_SET_THRTL > > > > + > > > > + 3. psr-hwinfo > > > > + Show PSR HW information, including L3 CAT/CDP/L2 CAT/MBA. > > > > + => XEN_SYSCTL_PSR_MBA_get_info > > > > > > 'psr-hwinfo' seems to be completely missing from the 'xl interfaces:' > > > section above. > > > > > Because this is not a newly added interface, I do not describe it in 'xl > > interfaces'. Is that necessary? > > Oh, OK, sorry for the noise. Then I guess it's not necessary to > describe it here. Maybe a reference to where 'psr-hwinfo' is described > would be nice (I assume there's a feature document somewhere that > describes 'psr-hwinfo'). > psr-hwinfo is firstly introduced in intel_psr_cat_cdp.pandoc. But MBA feature adds a new sysctl interface 'XEN_SYSCTL_PSR_MBA_get_info' which is used by psr-hwinfo. So, I describe it here again. > Roger. _______________________________________________ Xen-devel mailing list Xenfirstname.lastname@example.org https://lists.xen.org/xen-devel