> -----Original Message-----
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: 17 October 2017 07:43
> To: Paul Durrant <paul.durr...@citrix.com>
> Cc: Andrew Cooper <andrew.coop...@citrix.com>; Wei Liu
> <wei.l...@citrix.com>; George Dunlap <george.dun...@citrix.com>; Ian
> Jackson <ian.jack...@citrix.com>; sstabell...@kernel.org; xen-
> de...@lists.xenproject.org; konrad.w...@oracle.com; Tim (Xen.org)
> <t...@xen.org>
> Subject: Re: [PATCH v11 10/11] common: add a new mappable resource
> type: XENMEM_resource_grant_table
>
> >>> Paul Durrant <paul.durr...@citrix.com> 10/12/17 6:28 PM >>>
> >@@ -1608,7 +1608,8 @@ fault:
> >}
> >
> >static int
> >-gnttab_populate_status_frames(struct domain *d, struct grant_table *gt,
> >+gnttab_populate_status_frames(struct domain *d,
> >+ struct grant_table *gt,
> >unsigned int req_nr_frames)
>
> What is this change about?
>
It must have crept in accidentally. I'll get rid of it.
> >+int gnttab_get_grant_frame(struct domain *d, unsigned long idx,
> >+ mfn_t *mfn)
> >+{
> >+ struct grant_table *gt = d->grant_table;
> >+ int rc;
> >+
> >+ /* write lock required as version may change and/or table may grow */
> >+ grant_write_lock(gt);
> >+
> >+ rc = (gt->gt_version == 2 &&
> >+ idx > XENMAPIDX_grant_table_status) ?
>
> I don't understand this check - why does XENMAPIDX_grant_table_status
> matter here at all? Same in gnttab_get_status_frame() then.
>
Well, the current legal range of grant table frames for v2 is 0 - (1 <<
XENMAPIDX_grant_table_status) whereas it appears that for v1 there is no limit.
As for status frames, they are a v2-only concept but I agree that the range
check there is wrong.
Paul
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
