>>> On 08.11.17 at 21:19, <boris.ostrov...@oracle.com> wrote: > These tables are pointed to from FADT. Adding them will > result in duplicate entries in the guest's tables.
Oh, indeed. Just one small adjustment request: > +static bool __init pvh_acpi_table_in_xsdt(const char *sig) > +{ > + /* > + * DSDT and FACS are pointed to from FADT and thus don't belong > + * in XSDT. > + */ > + if ( !strncmp(sig, ACPI_SIG_DSDT, ACPI_NAME_SIZE) || > + !strncmp(sig, ACPI_SIG_FACS, ACPI_NAME_SIZE) ) > + return false; > + > + return true; > +} Please don't use two return statements in cases like this one - all can be had with a single one and no explicit uses of true or false. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel