Ian Campbell writes ("Re: [Xen-devel] [PATCH 06/29] libxl: Use libxl__xswait*
in libxl__ao_device"):
> On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote:
> > @@ -1164,7 +1136,7 @@ static void device_hotplug_clean(libxl__gc *gc,
> > libxl__ao_device *aodev)
> > {
> > /* Clean events and check reentrancy */
> > libxl__ev_time_deregister(gc, &aodev->timeout);
>
> You seem to have removed the initialisation of this in a previous hunk
> but not this deregistration or the field itself.
>
> Was that deliberate, perhaps it was serving dual purpose somewhere?
Yes. See "TODO: 4.2 Bodge due to QEMU, see comment on top of"...
in libxl__initiate_device_remove in libxl_device.c.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
