On Fri, 2015-04-17 at 22:33 +0800, Chao Peng wrote: > Add dedicated one to show hardware information. > > [root@vmm-psr]xl psr-cmt-hwinfo > Cache Monitoring Technology (CMT): > Enabled : 1 > Total RMID : 63 > Supported monitor types: > cache-occupancy > total-mem-bandwidth > local-mem-bandwidth > Nice.
> Signed-off-by: Chao Peng <chao.p.p...@linux.intel.com> > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -8014,6 +8014,36 @@ out: > } > > #ifdef LIBXL_HAVE_PSR_CMT > +static int psr_cmt_hwinfo(void) > +{ > + int rc; > + int enabled; > + uint32_t total_rmid; > + > I think you should still have something like: SWITCH_FOREACH_OPT(opt, "", NULL, "psr-cmt-hwinfo", 0) { /* No options */ } Or `xl psr-cmt-hwinfo -h' wouldn't work, would it? With that done: Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Regards, Dario
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel