On Fri, Apr 24, 2015 at 10:33 PM, Jan Beulich <jbeul...@suse.com> wrote:
>>>> On 24.04.15 at 10:19, <kai.hu...@linux.intel.com> wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>> @@ -64,6 +64,36 @@ integer_param("ple_gap", ple_gap);
>> static unsigned int __read_mostly ple_window = 4096;
>> integer_param("ple_window", ple_window);
>>
>> +static bool_t __read_mostly opt_pml_enabled = 0;
>> +
>> +/*
>> + * The 'ept' parameter controls functionalities that depend on, or impact
>> the
>> + * EPT mechanism. Optional comma separated value may contain:
>> + *
>> + * pml Enable PML
>> + */
>> +static void __init parse_ept_param(char *s)
>> +{
>> + char *ss;
>> +
>> + do {
>> + bool_t val = !!strncmp(s, "no-", 3);
>> + if ( !val )
>
> In case another round is needed, a blank line is missing above.
>
>> + s += 3;
>> +
>> + ss = strchr(s, ',');
>> + if ( ss )
>> + *ss = '\0';
>> +
>> + if ( !strcmp(s, "pml") )
>> + opt_pml_enabled = val;
>> +
>> + s = ss + 1;
>> + } while ( ss );
>> +}
>> +
>> +custom_param("ept", parse_ept_param);
>
> And a superfluous blank line would want to be dropped here.
Sure. Will do both of your above comments if a further v4 is needed. Thanks.
And I suppose you are talking about the blank line before
custom_param("ept", parse_ept_param) ?
Thanks,
-Kai
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
--
Thanks,
-Kai
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
