On 28/05/15 13:25, Tim Deegan wrote: > At 12:34 +0100 on 28 May (1432816489), Andrew Cooper wrote: >> Memory management is hard[citation needed]. Furthermore, it isn't helped by >> the inconsistent use of terms through the code, or that some terms have >> changed meaning over time. >> >> Describe the currently-used terms in a more practical fashon, so new code has >> a concrete reference. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Acked-by: Tim Deegan <t...@xen.org>, with one reservation. > >> + * - Phase out all use of gpfn/gmfn where it pertains to pfn or mfn. > I think you mean s/gpfn/gfn/, which I agree with. gmfn I'm not so > sure of. Shadow code uses variants on gmfn/smfn to denote pairs of > mfns (the guest's pagetable and its shadow), which I think is > defensible.
That was my intended meaning of "where it pertains to pfn or mfn", although I suppose I should have gone with my original sentence of "except in the shadow code, where gmfn has a distinct meaning". ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
