At 16:45 +0300 on 29 May (1432917959), Razvan Cojocaru wrote: > As suggested by Andrew Cooper, this patch attempts to remove > some redundancy and allow for an easier time when adding vm_events > for new control registers in the future, by having a single > VM_EVENT_REASON_WRITE_CTRLREG vm_event type, meant to serve CR0, > CR3, CR4 and (newly introduced) XCR0. The actual control register > will be deduced by the new .index field in vm_event_write_ctrlreg > (renamed from vm_event_mov_to_cr). The patch has also modified > the xen-access.c test - it is now able to log CR3 events. > > Signed-off-by: Razvan Cojocaru <rcojoc...@bitdefender.com> > Acked-by: Jan Beulich <jbeul...@suse.com>
Acked-by: Tim Deegan <t...@xen.org> FWIW, I think this: > +void hvm_event_cr(unsigned int index, unsigned long value, unsigned long > old); > +#define hvm_event_cr(what, new, old) hvm_event_cr(VM_EVENT_X86_##what, new, > old) is pretty nasty, and would prefer the function to have a different name from the macro, but I'm not going to push a v8 series out to v9 over it. Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
