Chunyan Liu writes ("[PATCH V5 3/7] libxl: add pvusb API"): > Add pvusb APIs, including: > - attach/detach (create/destroy) virtual usb controller. > - attach/detach usb device > - list usb controller and usb devices > - some other helper functions > > Signed-off-by: Chunyan Liu <cy...@suse.com> > Signed-off-by: Simon Cao <caobosi...@gmail.com>
I have reviewed the new API introduced in this patch and it looks sensible to me. I did notice this wrap damage: > +/* USB Devices */ > +int libxl_device_usb_add(libxl_ctx *ctx, uint32_t domid, libxl_device_usb\ *usb, > + const libxl_asyncop_how *ao_how) > + LIBXL_EXTERNAL_CALLERS_ONLY; > + > +int libxl_device_usb_remove(libxl_ctx *ctx, uint32_t domid, libxl_device_\ usb *usb, > + const libxl_asyncop_how *ao_how) I haven't reviewed the implementation (yet). Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel