On Tue, 2015-06-30 at 14:10 +0800, Wen Congyang wrote: It would be usual do describe here which commit caused the breakage (i.e. removed the parameter). Also please make the subject something more descriptive such as "remove now unnecessary gc from libxl__async_exec_start calls" e.g.
Subject: remove now unnecessary gc from libxl__async_exec_start calls These were removed in commit XXXXXX. > Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> > --- > tools/libxl/libxl_netbuffer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c > index ff2d6c7..107e867 100644 > --- a/tools/libxl/libxl_netbuffer.c > +++ b/tools/libxl/libxl_netbuffer.c > @@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, > libxl__remus_device *dev) > } > > setup_async_exec(dev, "setup"); > - rc = libxl__async_exec_start(gc, &dev->aodev.aes); > + rc = libxl__async_exec_start(&dev->aodev.aes); > if (rc) > goto out; > > @@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, > libxl__remus_device *dev) > > setup_async_exec(dev, "teardown"); > > - rc = libxl__async_exec_start(gc, &dev->aodev.aes); > + rc = libxl__async_exec_start(&dev->aodev.aes); > if (rc) > goto out; > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
