On Fri, 2015-06-26 at 10:34 +0100, Julien Grall wrote:
> Currently, it's hard to decide whether a part of the domain
> initialization should live in gicv_setup (part of the GIC
> driver) and domain_init (part of the vGIC driver).
>
> The code to initialize the domain for a specific vGIC version is always
> the same no matter the version of the GIC.
>
> Move all the domain initialization code for the vGIC in the respective
> domain_init callback of each vGIC drivers.
>
> Signed-off-by: Julien Grall <julien.gr...@citrix.com>
> Cc: Zoltan Kiss <zoltan.k...@huawei.com>
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index 341b6df..3c09c3e 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -67,6 +67,11 @@ unsigned int gic_number_lines(void)
> return gic_hw_ops->info->nr_lines;
> }
>
> +const struct gic_info *gic_info(void)
> +{
> + return gic_hw_ops->info;
This doesn't seem to be used here. Is it a remnant of the previous
approach?
> + if ( !platform_has_quirk(PLATFORM_QUIRK_GIC_64K_STRIDE) )
Perhaps the stride should be in the info struct?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
