On 06/30/2015 06:28 PM, Ian Campbell wrote: > On Thu, 2015-06-25 at 14:25 +0800, Yang Hongyang wrote: >> From: Wen Congyang <we...@cn.fujitsu.com> > > Refactor how? > > (Tip: In general no change can be sufficiently described in just the > subject line unless it is absolutely the most trivial possible one). > > It looks like mostly checkpoint_callback is renamed to > write_records_callback and the type of its argument and that of > completion_callback changed. But why?
checkpoint callback just write a record and return to the caller. For back channel, we also write a record from secondary to primary. So I rename it to write_records_callback. In secondary side, there is no libxl__domain_save_state, so I change the argument: use stream instead of dss. The caller can use container_of() to get dss. The back channel only needs this feature: use the read/write stream to read and write record. Thanks Wen Congyang > > > > . > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel