Andrew Cooper writes ("[PATCH v4 09/29] tools/libxl: Fix libxl__carefd_opened()
to be more useful with an invalid fd"):
> In the case that fd is -1, preserve errno and don't attempt to set
> CLOEXEC.
>
> Note that the implementation can still fail, as it ignores fcntl()
> errors and may not set CLOEXEC properly. Update the documentation
> accordingly until it is fixed.
Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
> Fixing the fnctl() error issue involves more TUITs than I currently
> have.
I think that if the fcntl set cloexec fails, we should probably abort
the program. Ian C, would that be OK with you ? If so then the
patch to fix this is trivial.
Otherwise all call sites need to grow error handling.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
